parser: Support [PARSER] sections in main configuration file #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nigel Stewart <[email protected]>
nigels-com
pushed a commit
that referenced
this pull request
Jan 27, 2020
When Fluent Bit encounters with a partial parser definition, it
crashes badly with a segmentation fault.
$ ./bin/fluent-bit -R parser.conf -c tail.conf
...
[2020/01/15 16:11:21] [error] [parser] no parser 'format' found for 'simple' in file 'conf/timestamp.parser'
[engine] caught signal (SIGSEGV)
#0 0x558bc4a0a226 in flb_parser_decoder_list_destroy() at src/flb_parser_decoder.c:700
#1 0x558bc4a05d75 in flb_parser_conf_file() at src/flb_parser.c:566
#2 0x558bc49f4bdd in flb_config_set_property() at src/flb_config.c:406
fluent#3 0x558bc49e24ae in flb_service_conf() at src/fluent-bit.c:446
fluent#4 0x558bc49e2f90 in main() at src/fluent-bit.c:807
fluent#5 0x7fa1cb7f109a in ???() at ???:0
fluent#6 0x558bc49e13a9 in ???() at ???:0
fluent#7 0xffffffffffffffff in ???() at ???:0
Aborted
This is just because `decoders` is not being initialized properly,
and that confuses Fluent Bit to deallocate a random memmory block
on the cleanup path. Fix it.
Signed-off-by: Fujimoto Seiji <[email protected]>
nigels-com
pushed a commit
that referenced
this pull request
Jan 27, 2020
When Fluent Bit encounters with a partial parser definition, it
crashes badly with a segmentation fault.
$ ./bin/fluent-bit -R parser.conf -c tail.conf
...
[2020/01/15 16:11:21] [error] [parser] no parser 'format' found for 'simple' in file 'conf/timestamp.parser'
[engine] caught signal (SIGSEGV)
#0 0x558bc4a0a226 in flb_parser_decoder_list_destroy() at src/flb_parser_decoder.c:700
#1 0x558bc4a05d75 in flb_parser_conf_file() at src/flb_parser.c:566
#2 0x558bc49f4bdd in flb_config_set_property() at src/flb_config.c:406
fluent#3 0x558bc49e24ae in flb_service_conf() at src/fluent-bit.c:446
fluent#4 0x558bc49e2f90 in main() at src/fluent-bit.c:807
fluent#5 0x7fa1cb7f109a in ???() at ???:0
fluent#6 0x558bc49e13a9 in ???() at ???:0
fluent#7 0xffffffffffffffff in ???() at ???:0
Aborted
This is just because `decoders` is not being initialized properly,
and that confuses Fluent Bit to deallocate a random memmory block
on the cleanup path. Fix it.
Signed-off-by: Fujimoto Seiji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nigel Stewart [email protected]
Work in progress.
Proof of concept.
Seems to work.